consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Fix a panic in connect-inject when the provided upstreams list is malformed

Open dhiaayachi opened this issue 9 months ago • 1 comments

Changes proposed in this PR

  • Fix a panic when parsing a malformed upstream, now a malformed upstream will be ignored
  • Support multiple separators between upstreams (, , ).

How I've tested this PR

Added unit tests to test multiple scenarios including malformed upstream lists

How I expect reviewers to test this PR

N/A

Checklist

dhiaayachi avatar Apr 29 '24 15:04 dhiaayachi

Thanks for fixing this :D! I think you're just missing a space separated case in your tests

This test case should cover it

dhiaayachi avatar Apr 29 '24 16:04 dhiaayachi