Damien Grisonnet comments

Results 522 comments of


                                            Damien Grisonnet

statusz: move componentName into registry

/triage accepted /assign

workqueue: add delayed metric

> This metric is suitable for an alert if it is above 0 for a long time. I wouldn't agree with that statement. It is pretty normal for workqueue items...

workqueue: add delayed metric

> I'm not sure I got your point. What your said is exactly the reason we are not satisfied with the existing retries metrics. We have many errors which are...

workqueue: add delayed metric

/triage accepted /assign

Promote workqueue metrics from ALPHA to BETA

/triage accepted

Add guidelines for metric graduation

cc @rexagod

perf: use concurrent map when storing metrics

/triage accepted /assign

perf: use concurrent map when storing metrics

The changes looks good to me, thank you @rarruda for pushing that improvement :) I'll update our perfs-tests and see how much we improve with this.

perf: use concurrent map when storing metrics

Please refrain from merging until we have the results.

perf: use concurrent map when storing metrics

I need to fix the tests, kms doesn't seem to be deploying properly in their CI cluster: https://github.com/kubernetes/perf-tests/pull/2920, but I don't have much time on my hands to look at...