kubernetes
Promote workqueue metrics from ALPHA to BETA
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Promote the workqueue metrics from alpha to beta as agreed upon in the issue. Note the most recent user-facing change I could find was in 2018: https://github.com/kubernetes/kubernetes/pull/71300
Which issue(s) this PR is related to:
Fixes #135463 KEP: https://github.com/kubernetes/enhancements/issues/1206
Special notes for your reviewer:
I'm fairly new to this metric promotion process. Please let me know if I need to change which KEP I'm referencing.
Does this PR introduce a user-facing change?
Promote workqueue metrics from ALPHA to BETA
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[KEP]: https://github.com/kubernetes/enhancements/tree/6c67c31ebeaf71083e22d7e5a8a66bc6587085df/keps/sig-instrumentation/1206-metrics-overhaul
/sig instrumentation
Hi @petern48. Thanks for your PR.
I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
This PR may require stable metrics review.
Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines.
This PR may require API review.
If so, when the changes are ready, complete the pre-review checklist and request an API review.
Status of requested reviews is tracked in the API Review project.
Looks like we recommended to go ahead with the promotion from ALPHA -> BETA here, so should be ok?
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dashpole, petern48
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~staging/src/k8s.io/component-base/metrics/OWNERS~~ [dashpole]
- ~~test/instrumentation/OWNERS~~ [dashpole]
- ~~test/instrumentation/testdata/OWNERS~~ [dashpole]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.
