Damien Grisonnet comments

Results 522 comments of


                                            Damien Grisonnet

introduce WatchListLatencyPrometheus measurement

Ah I see, seems like you did the work to setup watchlist already: https://github.com/kubernetes/test-infra/pull/29604

Flux custom metrics monitoring broken in 2.12

/assign @rexagod /triage accepted

fix: use --track-unscheduled-pods to select unscheduled pods in Daemonset sharding

LGTM

MON-1157: Revive prometheus metrics best practices

The initial concern with that test was that it might create disruption in CI if not done properly. I don't really know what would be the safest way to introduce...

Update the Compatibility Section in the Documentation to Explicitly Mention Supported kube-apiserver Skew

/assign @CatherineF-dev /triage accepted

Update the Compatibility Section in the Documentation to Explicitly Mention Supported kube-apiserver Skew

Cross linking the PR here: https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/177

Add compatibility matrix

I wonder if it could be worth adding a collumn for compatibility with Kubernetes. Like for example the recent metrics-server releases are still compatible with Kubernetes 1.19+ evne though they...

Add compatibility matrix

/triage accepted /assign

kube_endpoint_address duplicates with Prometheus 2.52

/assign /triage accepted

kube_endpoint_address duplicates with Prometheus 2.52

The bug lies in the fact that we don't distinguish between endpoint subsets. The metric was written in a way where we assumed that addresses and ports would always be...