perf-tests icon indicating copy to clipboard operation
perf-tests copied to clipboard
verified publisher icon kubernetes

introduce WatchListLatencyPrometheus measurement

Open p0lyn0mial opened this issue 2 years ago • 13 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

WatchListLatencyPrometheus measurement gathers 50th, 90th and 99th duration quantiles for watch list requests broken down by group, resource, scope.

The new metric (https://github.com/kubernetes/kubernetes/pull/120490) allows for comparing watch-list requests with standard list requests and measuring performance of the new requests in general.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

xref: https://github.com/kubernetes/enhancements/issues/3157

p0lyn0mial avatar Sep 11 '23 10:09 p0lyn0mial

/hold

we should wait for https://github.com/kubernetes/kubernetes/pull/120490

p0lyn0mial avatar Sep 11 '23 13:09 p0lyn0mial

https://github.com/kubernetes/test-infra/blob/a4926a4d0269828418698299e9643274ffd1b49a/config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml#L20-L21 seems like the right place to add the featuregate

dgrisonnet avatar Sep 19 '23 21:09 dgrisonnet

You perhaps need to enable the feature gate somewhere no?

I don't think so. I'm planning to use this measurement in the watchlist perf tests (https://github.com/kubernetes/perf-tests/pull/2316) which already setup the cluster to speak the streaming API.

p0lyn0mial avatar Sep 20 '23 07:09 p0lyn0mial

Isn't #2316 just a way to have the measurement displayed on the perf dashboard? Maybe it is already setup in test-infra, but I would have expected some code there to enable API streaming

dgrisonnet avatar Sep 20 '23 09:09 dgrisonnet

Ah I see, seems like you did the work to setup watchlist already: https://github.com/kubernetes/test-infra/pull/29604

dgrisonnet avatar Sep 20 '23 09:09 dgrisonnet

/hold cancel

this PR is ready for review

p0lyn0mial avatar Sep 28 '23 07:09 p0lyn0mial

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 22 '24 15:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 23 '24 15:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Apr 22 '24 16:04 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 22 '24 16:04 k8s-ci-robot

/reopen

p0lyn0mial avatar Apr 23 '24 08:04 p0lyn0mial

@p0lyn0mial: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 23 '24 08:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p0lyn0mial Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 23 '24 08:04 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar May 23 '24 08:05 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 23 '24 08:05 k8s-ci-robot

/reopen /remove-lifecycle rotten

p0lyn0mial avatar May 23 '24 10:05 p0lyn0mial

@p0lyn0mial: Reopened this PR.

In response to this:

/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 23 '24 10:05 k8s-ci-robot

The new PR is much better. Closing in favor of https://github.com/kubernetes/perf-tests/pull/2764

wojtek-t avatar Jul 26 '24 12:07 wojtek-t