dgodongm

Results 21 comments of dgodongm

@chadstewart @marktnoonan Can this be merged?

@chadstewart Friendly ping on this PR

@chadstewart @marktnoonan Could you take a look at this PR? One question (besides the E2E vs component test one mentioned in the description) is whether string checks are warranted (also...

@marktnoonan @chadstewart Gentle ping to see if you might have a chance to take a look this week.

@marktnoonan I made a pass at addressing your feedback. Let me know what you think. cc @chadstewart

@marktnoonan checking back on if the feedback revisions look ok

@marktnoonan Friendly nudge on this

@chadstewart @Tausifqureshi786 Let me know if you'd like me to finish this up. In terms of consistency with https://github.com/TechIsHiring/techishiring-website/blob/dev/src/components/organisms/footer/footer.cy.tsx, should the test file here be moved to be in same...

@chadstewart Ran across this when playing around with app. I'll try to poke around to investigate possible fix, but thought it might be worth capturing for now.

@chadstewart Perhaps this might get addressed when #133 is done?