techishiring-website icon indicating copy to clipboard operation
techishiring-website copied to clipboard

Refactor out header checks in homepage E2E tests

Open dgodongm opened this issue 1 year ago • 6 comments

Description

Created validateHeader util module with helper methods similar to validateFooter, and updated homepage E2E tests to use these, adding distinct test for mobile as well.

Related Issue

#121 - provides some E2E coverage instead of component as it seems there's technical impediment for the latter - see comments in this issue

Motivation and Context

Ensure more consistent approach between footer and header checks. And, adding some coverage for modal menu on mobile.

How Has This Been Tested?

Tested locally on Chrome

Screenshots (if appropriate):

n/a

dgodongm avatar Sep 27 '23 22:09 dgodongm

Someone is attempting to deploy a commit to a Personal Account owned by @TechIsHiring on Vercel.

@TechIsHiring first needs to authorize it.

vercel[bot] avatar Sep 27 '23 22:09 vercel[bot]

@chadstewart @marktnoonan What do you think of this refactoring, and additional mobile test?

dgodongm avatar Sep 27 '23 22:09 dgodongm

Thanks @marktnoonan! @chadstewart - any feedback or are you good with merging?

dgodongm avatar Oct 02 '23 21:10 dgodongm

@chadstewart @marktnoonan Can this be merged?

dgodongm avatar Oct 10 '23 13:10 dgodongm

@chadstewart this needs you to authorize the Vercel step. Or I can merge without that since it's just tests.

marktnoonan avatar Oct 10 '23 14:10 marktnoonan

@chadstewart Friendly ping on this PR

dgodongm avatar Oct 27 '23 23:10 dgodongm