techishiring-website icon indicating copy to clipboard operation
techishiring-website copied to clipboard

[BUG]: Hamburger menu doesn't get dismissed on mobile when clicking item

Open dgodongm opened this issue 1 year ago • 3 comments

Hamburger menu doesn't get dismissed on mobile when clicking item. Selected page is opened, but underneath the menu. Short video attached:

https://github.com/TechIsHiring/techishiring-website/assets/123777263/df125e61-1c73-4ebd-863d-b7c76d13dda6

Expected Behavior

Menu should close when clicking item

Current Behavior

Menu remains open

Possible Solution

Have not investigated code fix, but behavior change should be to dismiss/collapse menu

Steps to Reproduce

  1. On mobile or mobile sized viewport, go to https://www.techishiring.com/
  2. Click on Hamburger menu and click About (or other menu item)

dgodongm avatar Sep 19 '23 17:09 dgodongm

@chadstewart Ran across this when playing around with app. I'll try to poke around to investigate possible fix, but thought it might be worth capturing for now.

dgodongm avatar Sep 19 '23 17:09 dgodongm

@chadstewart Perhaps this might get addressed when #133 is done?

dgodongm avatar Sep 20 '23 02:09 dgodongm

It seems issue only happens with relative links. I noticed that the "Main Nav" molecule story doesn't have the issue so I updated the About link locally to point to https://www.google.com (like the "Main Nav" molecule story) and hamburger menu closes/collapses as expected. Doesn't get to root of issue, but at least better isolated.

dgodongm avatar Sep 20 '23 03:09 dgodongm