Kai Pastor
Kai Pastor
Hm, `x-` has its own world of associations. Is `xtensor-` a candidate?
AFAIU this is a new tool port. Name and implementation would need to be aligned with https://github.com/microsoft/vcpkg/pull/31748. Cf. "Outstanding guidelines notes" there.
> AFAIU this is a new tool port. Name and implementation would need to be aligned with #31748. Cf. "Outstanding guidelines notes" there. > [FrankXie05](https://github.com/FrankXie05) added https://github.com/microsoft/vcpkg/labels/info%3Areviewed label IMO this...
> > Checking the builds on osx and linux. Will post the findings. > > ICU on osx and linux is creating issues. There's an existing issue #36171 > >...
~~~ FAILED: bin/TestWebKitAPI/TestWTF ... /usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicuuc.a(udata.ao): in function `openCommonData(char const*, int, UErrorCode*)': /mnt/vcpkg-ci/b/icu/x64-linux-dbg/common/.././../src/c-74_1-src-8ca76704fa.clean/source/common/udata.cpp:699: undefined reference to `icudt74_dat' /usr/bin/ld: /mnt/vcpkg-ci/b/icu/x64-linux-dbg/common/.././../src/c-74_1-src-8ca76704fa.clean/source/common/udata.cpp:722: undefined reference to `icudt74_dat' ~~~ So the question is why it...
> But that makes the PR checks fail. No.
The logs are available as downloadable "artefacts" for that CI run. - on the summary page via "\ published", https://dev.azure.com/vcpkg/public/_build/results?buildId=98677&view=results - on the job page via "\ artifacts produced", https://dev.azure.com/vcpkg/public/_build/results?buildId=98677&view=logs&j=84da4f4a-968a-5b5c-16e9-f444c845396d...
> Automake needs updating for `libidn2` to pass on android 1. I'm not convinced. It builds with `vcpkg_configure_make` now, in vcpkg CI and locally, with automake 1.16.1. 2. "Automake needs...
Please drop a note when this is "ready for review".
> I took your previous comment to mean "don't compare cmake variables to any particular literal" This was the must-have. And there still is: https://github.com/microsoft/vcpkg/pull/39050/files#diff-ec85869615f18a9570937cbc887348e720f2c195157eefe38f9dad3660913a58R443 But this should not be...