[sparrow] Add `sparrow`
- [x] Changes comply with the maintainer guide.
- [x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
- [x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx. - [x] The versioning scheme in
vcpkg.jsonmatches what upstream says. - [x] The license declaration in
vcpkg.jsonmatches what upstream says. - [x] The installed as the "copyright" file matches what upstream says.
- [x] The source code of the component installed comes from an authoritative source.
- [x] The generated "usage text" is accurate. See adding-usage for context.
- [x] The version database is fixed by rerunning
./vcpkg x-add-version --alland committing the result. - [x] Only one version is in the new port's versions file.
- [x] Only one version is added to each modified port's versions file.
The usage test passed on x64-windows (header files found):
sparrow is header-only and can be used from CMake via:
find_path(SPARROW_INCLUDE_DIRS "sparrow/buffer.hpp")
target_include_directories(main PRIVATE ${SPARROW_INCLUDE_DIRS})
Thank you, @MonicaLiu0311.
- The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
This does not seem to be correct. This project is not associated with sparrow on repology, and first search results point to https://github.com/ropas/sparrow , not https://github.com/xtensor-stack/sparrow .
Would you accept xtensor-stack-sparrow ?
x-sparrow would work for us as the ownership might be shared beyond the xtensor-stack's organization.
Hm, x- has its own world of associations. Is xtensor- a candidate?
Is xtensor- a candidate?
We'd like to keep it for xtensor bindings on sparrow. Would cpp-sparrow be ok (as suggested by the last change)?
@ vcpkg team: Are we OK with cpp-sparrow?
Also, should we say this depends on https://github.com/microsoft/vcpkg/pull/37457 so that the patch is unnecessary? (I'm a bit uneasy patching a version that upstream explicitly picked)
@dan-shaw @ras0219-msft @vicroms and I discussed this today. We make the following observations:
- Searching for cpp-sparrow does not lead one to this package on common search engines
- Searching for cpp-sparrow on GitHub leads to a flappy bird clone
We would really like the name to be xtensor-sparrow or xtensor-stack-sparrow (with a mild preference for the latter as it follows the [github org]-[project] pattern) before we merge this.
Also, should we say this depends on #37457 so that the patch is unnecessary? (I'm a bit uneasy patching a version that upstream explicitly picked)
#37457 is now merged so the patch should be no longer necessary.
We'd like to keep it for xtensor bindings on sparrow. Would cpp-sparrow be ok (as suggested by the last change)?
This name is the name of the repository. If xtensor-stack is really trying to save that name for something else, they'd have to rename the repo anyway, so we don't understand the problem here. Perhaps xtensor-cpp-sparrow or xtensor-stack-cpp-sparrow would work?
The thing is that sparrow will be transfered to the man-group org when it's more stable. Would man-group-sparrow be acceptable?
The thing is that
sparrowwill be transfered to the man-group org when it's more stable. Would man-group-sparrow be acceptable?
Can't we just rename the port if/when that happens?
Does renaming the port makes the old name available again? If so, could name this port xtensor-stack-sparrow for now, and rename it when xtensor-stack/sparrow becomes man-group/sparrow? Alternatively, let's keep this PR open to check we don't break the build until the transfer.
Does renaming the port makes the old name available again?
No, in general people would have to update their references. But they'd have to do that referencing the github repo in the first place.
Hello @BillyONeal,
The project has been transferred to another organization, and this PR is now ready for another review. :slightly_smiling_face:
The naming concern remains. Would you accept man-group-sparrow to follow the [github organization]-[repo] convention?
Can we actually reconsider sparrow as a name since https://github.com/ropas/sparrow is a small, unmaintained OCAML project?
I would love this to be named sparrow. It would save us the trouble of having to tell people to use a different name on vcpkg.
The problem with the name sparrow is again, not in repology, and search hits lead to
- ropas/sparrow
- Sparrow-lang/sparrow
which are not this.
@AugP @ras0219-msft @data-queue @JavierMatosD and I discussed this today.
We affirm what we said back in March, there's too much potential for confusion and we want the name to be man-group-sparrow.
Ping @jjerphan
Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.