Kai Pastor
Kai Pastor
What kind of breakage happens with `autoreconf -vfi`? What about the proposal to add `AC_CONFIG_MACRO_DIR([m4])`?
> I normally do that - but I thought the bots here didn't like that? There is only one relevant bot, checking that the git tree object referenced in `versions`...
> > Can you please resolve the file conflicts? > > Thanks. > > Certainly. I thought I had, but I think I must've rebased on an older version of...
Now with dynamic community triplets, handling `vcpkg_fixup_pkgconfig` would be beneficial even without additional polyfill for static triplets.
Yes. `SKIP_CONFIGURE` is not used when both `confgure` and `configure.ac` are present: https://github.com/microsoft/vcpkg/blob/9f04533f307a8560cc1cc5c1fdee0d88d6d7d818/scripts/cmake/vcpkg_configure_make.cmake#L247-L253
> @dg0yt `SKIP_CONFIGURE` temporary can't be used now. "Can't be used" == "defect"
The new `cmake_path(NATIVE_PATH )` doesn't seem to have this problem. However, the `vcpkg.cmake` toolchain file cannot expect CMake 3.20 so far.
BTW `TO_NATIVE_PATH` doesn't seem right for values which are used in CMake commands.
Just tried ffmpeg:arm64-linux: The portfile's prefix detection is wrong and passes `--cross-prefix=//aarch64-linux-gnu-` when it should pass `aarch64-linux-gnu-`. https://github.com/microsoft/vcpkg/blob/e6a000679745f8ea3f98067e5f3753d3cbecb948/ports/ffmpeg/portfile.cmake#L463-L466 Here, the regex should be: `"([^\/]*-)gcc$"`. I just added related code in...
@Cheney-W My comment only deals with `cross_prefix`, https://github.com/microsoft/vcpkg/issues/26048#issuecomment-1204849497. Windows triplets is a different story. `-Fo/c/Users/XXXX/AppData/Local/Temp/ffconf.xmA29ylu/test.o` seems to target `C:\Users\XXXX\AppData\Local\Temp\ffconf.xmA29ylu\test.o`, but the error message reports `D:\c\Users\XXXX\AppData\Local\Temp\ffconf.xmA29ylu\test.o`. At some point, there is...