Dan Foreman-Mackey

Results 547 comments of Dan Foreman-Mackey

I think the Zenodo problems are actually deeper. A year ago or more Zenodo changed their API in non backward compatible ways which means that we'd probably need to re-implement...

Thanks! Can you also add a test based on #24073? It probably makes sense for it to live in [`tests/lax_numpy_test.py`](https://github.com/jax-ml/jax/blob/816947b6566c9c759fd436fe04b188f41e8ba9a6/tests/lax_numpy_test.py#L893-L933) near the existing test.

@scottstanie — I wanted to check in here on this old PR. I believe that we were still waiting on some final tweaks related to broadcasting semantics. Are you still...

Thanks for the updates! It looks like this still doesn't work for some test cases. You should be able to run the test suite locally using: ``` pytest tests/lax_numpy_test.py:: LaxBackedNumpyTests...

You may need to set the environment variable `JAX_NUM_GENERATED_CASES=25` because the `sample_product` decorator might not be generating all the failing test by default. The ARM "success" is a red herring:...

Thanks! We're looking really close now, but there's one last failure. It looks like that's when the `JAX_ENABLE_X64=1` env variable is set too. (This also affects which test cases are...

Awesome - thanks for pushing this through. Looks good now! Last request: can you squash your commits into one and rebase onto the `main` branch? (Some notes here: https://docs.jax.dev/en/latest/contributing.html#single-change-commits-and-pull-requests) Then...

@catrionamurray — thanks! This is a known issues that we definitely need to fix! You can get around this using the following suggestion: https://github.com/rodluger/starry/issues/302#issuecomment-1094136350 (although I think it perhaps actually...

@MichaelHudgins — Absolutely! For now a single GPU is all we need. There's also no major rush to landing this, so just keep me posted on when it should be...

Thanks @MichaelHudgins! This works perfectly. It was very easy to get this up and running - thanks for all your work on this!! Peter is OOO this week, so I'll...