Dan Foreman-Mackey
Dan Foreman-Mackey
@sblunt — Checking in here to make sure that this is on your radar. Please get started with your review ASAP. Thanks! @sybreton — Also please let me know if...
@sybreton, @sblunt, @darthoctopus — I'm just stopping by to check in on how this review is going. Please let me know if there's anything I can do to help get...
@sblunt, @sybreton — Thanks for your work on this so far!! @darthoctopus — It looks to me like the ball is in your court to respond to the issues the...
@editorialbot generate pdf
@editorialbot check references
I'm starting to take a look at this and we'll see how far I get. To begin with, I'm looking at the jaxpr for each calculation. I started with just...
Oh - I think I know what it is! We should probably just merge the two implementations: we should use the closed form solution for `s0` and `s2`, and then...
See https://github.com/exoplanet-dev/jaxoplanet/pull/204
Thanks for the report! I'd be happy to review a PR that adds the appropriate copy, but please keep the same default value since some downstream dependencies rely on that...
Very cool! Thanks for sharing.