Dan Foreman-Mackey

Results 547 comments of Dan Foreman-Mackey

I don't know the answer to this, but maybe @jakevdp does? Some notes in the meantime. It's worth checking out the [JAX microbenchmark FAQ entry](https://jax.readthedocs.io/en/latest/faq.html#benchmarking-jax-code) because benchmarking like you're doing...

It looks like you're running a really old version of JAX (0.4.13; the current version is 0.4.31). You'll probably need to update your Python version because 3.8 is no longer...

Given the 🎉 reaction, I'm going to hope that you got this sorted out on your end @MikaBell and close this issue. Please feel free to comment or open a...

I _think_ this is actually a bug (although @mattjj and @froystig will know better, of course!). If we update `f_jvp` to: ```python @f.defjvp def f_jvp(indices, primals, tangents): x, = primals...

OK maybe I take that back! It's clear from this error message: https://github.com/google/jax/blob/82d3cfb3c6f88321f0b29b4cc41134a464de82c2/jax/_src/custom_derivatives.py#L656-L662 that custom _VJP_ at least has this requirement that nondiff args cannot be tracers. I think it...

Thanks! Would you be willing to also add a test for this behavior in [`test_hist2d`](https://github.com/dfm/corner.py/blob/main/tests/test_hist2d.py)?

@sybreton, @sblunt — This is the review thread for the paper. All of our correspondence will happen here from now on. Thanks again for agreeing to participate! 👉 **Please read...

@sybreton — Many thanks for bringing this up! Like @warrickball says, this type of co-authorship within a large collaboration can typically be waived unless anyone involved in the review has...

@sybreton — Thanks for checking this! This all sounds completely fine to me, especially now that you've disclosed this potential COIs. I'm happy to proceed with the review with you...