Darragh Fitzmaurice

Results 125 comments of Darragh Fitzmaurice

/remove-label peer-review-needed /label peer-review-in-progress

Hi @sjhala-ccs . Nice work. I added comments inline. Some will need to be addressed before the merge review can take a look. Such as: Steps documented outside a procedure...

/remove-label peer-review-in-progress /label peer-review-done As all my comments are resolved, I'll take it that the red text under the `data:` segment for the `Example output config map (success)` is expected?...

> spec.timeout: 10m Hi @sjhala-ccs . I checked the other examples and it looks like values for the `data` parameter do render in red, so all is good here. Please...

> > spec.timeout: 10m > > Hi @sjhala-ccs . I checked the other examples and it looks like values for the `data` parameter do render in red, so all is...

/remove-label peer-review-needed /label peer-review-in-progress

/remove-label peer-review-needed /label peer-review-in-progress

Hi @opayne1 and @cbippley . Please see [this Slack thread](https://redhat-internal.slack.com/archives/C04DLQNN7B9/p1719851705754149?thread_ts=1719847231.678849&cid=C04DLQNN7B9) for why a CM was not needed.

/remove-label peer-review-needed /label peer-review-in-progress

Hi @agantony . Please squash the commits on this PR.