openshift-docs
openshift-docs copied to clipboard
openshift
CNV#28092: Added procedure to run storage checkup
Version(s): 4.15+
Issue: CNV-28092
Link to docs preview: https://73695--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/monitoring/virt-running-cluster-checkups#virt-checking-storage-configuration_virt-running-cluster-checkups
QE review:
- [ ] QE has approved this change.
@sjhala-ccs: This pull request references CNV-28092 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: CNV-28092
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sjhala-ccs: This pull request references CNV-28092 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: CNV-28092
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sjhala-ccs: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.
In response to this:
Version(s): 4.15+
Issue: CNV-28092
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Wed May 22 11:47:34 - Prow CI generated the docs preview:
https://73695--ocpdocs-pr.netlify.app/openshift-dedicated/latest/virt/monitoring/virt-monitoring-overview.html https://73695--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/monitoring/virt-monitoring-overview.html https://73695--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/monitoring/virt-running-cluster-checkups.html https://73695--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/monitoring/virt-monitoring-overview.html
Hi @sjhala-ccs . Nice work. I added comments inline. Some will need to be addressed before the merge review can take a look. Such as: Steps documented outside a procedure subheading and the YAML colouring.
/remove-label peer-review-in-progress
/label peer-review-done
As all my comments are resolved, I'll take it that the red text under the data: segment for the Example output config map (success) is expected? Also the steps at the start of the "Running a storage checkup" section are intended (although they should belong in their own procedure)?
As all my comments are resolved, I'll take it that the red text under the
data:segment for theExample output config map (success)is expected? Also the steps at the start of the "Running a storage checkup" section are intended (although they should belong in their own procedure)?
@dfitzmau I pushed the updates incorporating your review comments. As mentioned in my responses to your comments, I have removed the steps at the start of the procedure. I also added the subs="attributes+", but the color issue is still not resolved.
spec.timeout: 10m
Hi @sjhala-ccs . I checked the other examples and it looks like values for the data parameter do render in red, so all is good here. Please ignore the YAML color query. When I check the preview link, I still see:
spec.timeout: 10m
Hi @sjhala-ccs . I checked the other examples and it looks like values for the
dataparameter do render in red, so all is good here. Please ignore the YAML color query. When I check the preview link, I still see:
These steps could be dropped as this is arleady what's happening in the procedure. Given the short size of the module, I do not think summarizing the steps in the opening section of the module is necessary.
These steps could be dropped as this is arleady what's happening in the procedure. Given the short size of the module, I do not think summarizing the steps in the opening section of the module is necessary.
I only added the storage checkup procedure as part of this PR. I have removed the summary steps from that procedure.
@sjhala-ccs: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sjhala-ccs: new pull request created: #76351
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@sjhala-ccs: new pull request created: #76352
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.