Darren Fennessy

Results 16 comments of Darren Fennessy

@JStickler @rahulanand16nov The preview is in the description. Please continue all reviews in this PR. Julie, please close: https://github.com/openshift/openshift-docs/pull/46998 Thank you :)

@azgabur I've made the update we discussed on Slack: https://47204--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-threescale-webassembly-module.html#ossm-threescale-applying-external-service-entry-objects_ossm-threescale-webassembly-module

> Looks good! I give it LGTM Awesome! Thanks @azgabur @JStickler Hopefully we can now merge this PR. Cheers :slightly_smiling_face:

> > Looks good! I give it LGTM > > Awesome! Thanks @azgabur > > @JStickler Hopefully we can now merge this PR. Cheers slightly_smiling_face cherry-pick 4.6 to 4.11

FYI @azgabur https://47204--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-threescale-webassembly-module.html#ossm-threescale-applying-external-service-entry-objects_ossm-threescale-webassembly-module

/label peer-review-needed This was originally under review by Julie Stickler. I made updates based on her last peer review, so it needs at least on more review. Cheers. 3scale eng/QE...

> @dfennessy, is that for a re-review? Thanks! Yes, my apologies. I thought @tmalove would sign off on the latest updates from her suggestions. Thanks @jboxman-rh

> > Once approved, please merge and cherry-pick: 4.6 to 4.11 > > @dfennessy hi! Is there a specific reason why this should not also be cherry picked to 4.12?...

> @dfennessy I have completed my review of this PR. Please let me know if you have any questions about my suggestions. Thanks! @pneedle-rh Thanks for thorough review. I've made...