openshift-docs
openshift-docs copied to clipboard
openshift
THREESCALE-7919: Added content for the DestinationRule custom resource
Work done for Jira Issue THREESCALE-7919
Reviewers
- @JStickler
- @rahulanand16nov (3scale SME)
- @azgabur (3scale QE)
Preview: http://file.rdu.redhat.com/dfenness/THREESCALE-7919/service_mesh/v2x/ossm-threescale-webassembly-module.html#ossm-threescale-applying-external-service-entry-objects_ossm-threescale-webassembly-module
@JStickler @rahulanand16nov
The preview is in the description. Please continue all reviews in this PR.
Julie, please close: https://github.com/openshift/openshift-docs/pull/46998
Thank you :)
🤖 Updated build preview is available at: https://47204--docspreview.netlify.app
Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/2295
@azgabur I've made the update we discussed on Slack: https://47204--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-threescale-webassembly-module.html#ossm-threescale-applying-external-service-entry-objects_ossm-threescale-webassembly-module
Looks good! I give it LGTM
Awesome! Thanks @azgabur
@JStickler Hopefully we can now merge this PR. Cheers :slightly_smiling_face:
Looks good! I give it LGTM
Awesome! Thanks @azgabur
@JStickler Hopefully we can now merge this PR. Cheers slightly_smiling_face
cherry-pick 4.6 to 4.11
FYI @azgabur
https://47204--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-threescale-webassembly-module.html#ossm-threescale-applying-external-service-entry-objects_ossm-threescale-webassembly-module
/label peer-review-needed
This was originally under review by Julie Stickler. I made updates based on her last peer review, so it needs at least on more review. Cheers.
3scale eng/QE have approved.
Thanks in advance for your support :slightly_smiling_face:
Once approved, please merge and cherry-pick: 4.6 to 4.11
@dfennessy, is that for a re-review? Thanks!
Yes, my apologies. I thought @tmalove would sign off on the latest updates from her suggestions.
Thanks @jboxman-rh
Once approved, please merge and cherry-pick: 4.6 to 4.11
@dfennessy hi! Is there a specific reason why this should not also be cherry picked to 4.12? Thanks!
Once approved, please merge and cherry-pick: 4.6 to 4.11
@dfennessy hi! Is there a specific reason why this should not also be cherry picked to 4.12? Thanks!
Hi Paul, No reason. Please cherry-pick to 4.12 also. Cheers.
Hi Paul, No reason. Please cherry-pick to 4.12 also. Cheers.
Ok, thank you for confirming that. I have subsequently added the enterprise-4.12 label.
@dfennessy I have completed my review of this PR. Please let me know if you have any questions about my suggestions. Thanks!
@pneedle-rh Thanks for thorough review. I've made updates based on your suggestions.
The PR has been approved by 3scale SME and QE.
I need a peer reviewer LGTM so that I can add the label for merge-review-needed.
Cheers
@dfennessy I have added a few additional comments, following the updates relating to the structure of the procedural steps. Please let me know if you have any questions about my additional suggestions. Thanks!
@pneedle-rh Thanks. Updates made.
@dfennessy There is content in this PR that I could not find in the preview. Please re-apply the merge request when it's updated :)
/label merge-review-needed
@stevsmit Please see the link in the description. The previous link was from when we had to generate builds manually.
Cheers.
/label merge-review-needed
@stevsmit: new pull request created: #52221
In response to this:
/cherrypick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@stevsmit: new pull request created: #52222
In response to this:
/cherry-pick enterprise-4.11
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@stevsmit: new pull request created: #52223
In response to this:
/cherry-pick enterprise-4.10
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.