Doug Fawley

Results 426 comments of Doug Fawley
trafficstars

@PapaCharlie Do you have any response to the concurrency issues raised in the first comment? Do you think we could remove the atomics, or maybe something is needed to address...

@Groxx we will need you to complete the CLA in order to merge this, thanks!

> Absolutely, hence calling them Unsafe in the first place. However, without that specific unsafe usage being made available by the mem package, it wasn't really possible to introduce this...

This is the standard [Linux Foundation](https://en.wikipedia.org/wiki/Linux_Foundation) / [CNCF](https://en.wikipedia.org/wiki/Cloud_Native_Computing_Foundation) CLA, and the repo requires signing the agreement in order to merge pull requests. If you don't want to sign it, that's...

There's also some chance you may have attempted to go through the "corporate" license workflow instead of the "individual" one. Asking around, nobody was aware that you'd need to provide...

Blocked on the CLA issue; being investigated in https://github.com/communitybridge/easycla/issues/4638

@Groxx can you try again? IIUC they removed the address requirement.

(2) is actually tricky to fix, because there is a behavior change that is required: ```go func ClientStreamingMethodHandler(stream ___) error { // ... stream.SendAndClose(responseMessage) stream.SetTrailer(...) return nil } ``` This...

> @dfawley, Mark is the listed approver currently, but I'm fine merging this as it seems things are in order. Since the first implementation is in Go, you may want...