Doug Fawley

Results 465 comments of Doug Fawley

Closing until a strategy for logging (etc) node ID is decided.

> RELEASE NOTES: > * Fix race condition that could lead to multiple transports being created in parallel. What is the user-visible symptom here? A memory leak? Or just an...

Thanks for reporting this. @eshitachandwani probably the right fix is to also avoid the proxy from inside the delegating resolver when the target resolver produces addresses whose `networktype` is anything...

@easwars can you document some requirements for this test so we can have someone else write it if needed?

I believe this was supposed to be fixed by #7523. Maybe that wasn't effective enough?

> vet: add check for trailing spaces Release notes are for users. Only gRPC-Go developers will care about vet. `None` is appropriate here.

I will push a commit that has some edits soon, rather than going back and forth in comments.

Should this link to https://github.com/grpc/proposal/blob/master/A24-lb-policy-config.md instead?

> @dfawley Can you add a little bit of color for where the usage of this comes up and how valuable it is given the tradeoff context The first example...

> @janardhanvissa could you add the screenshots of traces on clients and server please? For the future, for text output, can we please use a github gist or pastebin instead...