Doug Fawley

Results 467 comments of Doug Fawley

Yes, I think this is just an oversight in our code here. If `SendMsg` returns `io.EOF`, we should call `RecvMsg` and use the error there. I believe it's possible for...

No problem! This is rare but probably important enough that we should prioritize this internally. Also the fix is probably quite easy.

@Kailun2047 Sure, that sounds good to me, as long as you think you can work on it pretty soon. For the repro, I wonder if we can reproduce it by...

Oh interesting. I thought it was something simpler, but you're right - some of the streaming code actually checks the type of the RPC and adjusts its behavior accordingly. If...

Returning `io.EOF` here would break existing code quite badly - our generated code relies upon `SendMsg` not returning an error on success. So we should update the docs to say...

https://github.com/grpc/grpc-go/actions/runs/13995572280/job/39189763350?pr=8187#step:8:1385

It might be good to measure the frequency of this one again. It seems to happen quite a bit.

I think we should leave this open until we decide what the behavior _should_ be.

I believe we've fully committed to making it INTERNAL. I don't think we need to wait on a doc update to implement it. @ejona86 WDYT?

Per @ejona86 offline, it's fine to go ahead and make this change before the gRFC happens. We've agreed on that change, just need to go through the process to make...