Doug Fawley

Results 434 comments of Doug Fawley
trafficstars

C++ is not my area so I will recuse myself from approving this PR. I was only pinging it as part of an ongoing effort to ensure PRs don't linger...

Ping @DenisPavlov; are you able to complete this? If not maybe send a new PR using the ID that you signed the CLA with?

This is some minor wordsmithing but seems fine to me. @chalin?

This topic has come up before and IIRC we decided to punt on it. Technically, it's not too hard to split it out, since it's in a separate package. However,...

https://github.com/grpc/grpc-go/actions/runs/5073008191/jobs/9111471736?pr=6314#step:8:198

https://github.com/grpc/grpc-go/actions/runs/5134976897/jobs/9239750602?pr=6331#step:8:198

https://github.com/grpc/grpc-go/actions/runs/5193271248/jobs/9363590170?pr=6351#step:8:200

It should be possible to metadata key names ending with `-bin`, and gRPC will base64 encode/decode them on the wire.