grpc.io icon indicating copy to clipboard operation
grpc.io copied to clipboard

Published 20 hours ago • verified publisher icon grpc

Limit Concurrent Processes of Initial Build to 8

Open tylercasper opened this issue 3 years ago • 8 comments
trafficstars

Fixes #982, to recommend building with 8 concurrent process, rather than an unlimited number.

tylercasper avatar Jun 10 '22 01:06 tylercasper

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: tylercasper / name: Tyler Casper (f81b515dc03f29f602e1220f4555809085b784b4)

linux-foundation-easycla[bot] avatar Jun 10 '22 01:06 linux-foundation-easycla[bot]

CC @jtattermusch

gnossen avatar Jun 15 '22 17:06 gnossen

(From memory, this might not be the first time that this issue is raised. Maybe Jan's suggestion of -j4 (used consistent in all command instances makes the most sense.)

chalin avatar Jul 07 '22 21:07 chalin

Maybe just add a quick note about the number being configurable

yashykt avatar Jul 20 '22 18:07 yashykt

@chalin leaving the final decision up to you (also see @yashykt 's comment).

jtattermusch avatar Aug 16 '22 12:08 jtattermusch

@yashykt - can you make the updates?

chalin avatar Aug 16 '22 12:08 chalin

Ping @yashykt

dfawley avatar Sep 21 '22 20:09 dfawley

Ping @yashykt

XuanWang-Amos avatar Oct 05 '22 22:10 XuanWang-Amos

I rebased and implemented the changes that Jan suggested. @dfawley and/or @jtattermusch PTAL and give this a final approval. I or you can merge after that. Thanks all!

chalin avatar Oct 28 '22 15:10 chalin

C++ is not my area so I will recuse myself from approving this PR. I was only pinging it as part of an ongoing effort to ensure PRs don't linger for too long.

dfawley avatar Oct 28 '22 16:10 dfawley

Thanks @jtattermusch.

chalin avatar Oct 31 '22 17:10 chalin