Daniel Wyatt comments

Results 6 comments of


                                            Daniel Wyatt

mingw-w64-x86_64-libbotan 2.14+ hangs after main() when threads are enabled (only in DLLs)

> As a workround I would recommend instead of `--without-os-feature=threads` using `--disable-modules=thread_utils` since `without-os-feature` also disables all provisions for locking etc so if someone used it in a MT app...

mingw-w64-x86_64-libbotan 2.14+ hangs after main() when threads are enabled (only in DLLs)

(Still hangs with both patches) EDIT: *either, to be clear

Explicitly initialize POD struct fields.

> maybe just > `memset(&s, 0, sizeof some_struct_t); ` > ? It's not very C++-y, it relies on all members remaining POD, and it seems maybe more likely to be...

Update set_rnp_log_switch() to allow logging fd.

This is already available via `rnp_ffi_set_log_fd` for functions that use `FFI_LOG`, right? That was the original idea there, we just didn't update everything to use `FFI_LOG` yet.

Update set_rnp_log_switch() to allow logging fd.

> @dewyatt `FFI_LOG()` requires `rnp_ffi_t` instance, while `RNP_LOG` works on lower layers, where it will be unavailable. However, `rnp_ffi_set_log_fd()` could also set lower-layer global variable, what do you think about...

Used maximum password request tries.

This is a good start but I think it's incomplete. * Personally I'd prefer an argument name like `password-attempts` vs `num-tries`. * I'm thinking `rnpkeys` should also accept and utilize...