rnp icon indicating copy to clipboard operation
rnp copied to clipboard

Used maximum password request tries.

Open joke325 opened this issue 4 years ago • 3 comments

Closes #913

joke325 avatar Apr 28 '20 20:04 joke325

Codecov Report

Merging #1112 into master will decrease coverage by 0.01%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   83.41%   83.40%   -0.02%     
==========================================
  Files          76       76              
  Lines       29720    29724       +4     
==========================================
  Hits        24792    24792              
- Misses       4928     4932       +4     
Impacted Files Coverage Δ
src/rnp/fficli.cpp 71.89% <0.00%> (-0.22%) :arrow_down:
src/rnp/rnpcfg.cpp 67.87% <100.00%> (+0.40%) :arrow_up:
src/librepgp/stream-write.cpp 78.93% <0.00%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56d9ae9...ccbfe01. Read the comment docs.

codecov[bot] avatar Apr 28 '20 20:04 codecov[bot]

The windows workflow here is broken despite how many times I "retry", it can't checkout the ref... Can someone do a manual rebase?

ronaldtse avatar May 05 '20 17:05 ronaldtse

This is a good start but I think it's incomplete.

  • Personally I'd prefer an argument name like password-attempts vs num-tries.
  • I'm thinking rnpkeys should also accept and utilize this argument.
  • I don't think rnp actually utilizes this, does it?

dewyatt avatar May 05 '20 22:05 dewyatt