Yaroslav Admin

Results 110 comments of Yaroslav Admin

Maybe it's more of Angular than Angular CLI bug (wasn't able to find an existing issue for the problem in either repository) or some very stupid mistake, but it looks...

I'm strongly against adding it to the table as all other JS parsers, transpilers, polyfills and similar libraries. It just does not belong here. I'm also against having transpilers, shims...

Yes, makes total sense to me!

I think we should add both. PR is welcome :)

To be honest, I don't quite agree with these changes as I don't see what problem do they solve. The post-merge is expected to fail sometimes because it runs tests...

> I encountered that commitlint fails in windows currently, so contributors could not run it if working in that OS. Do you refer to the `` npm run commitlint --...

> Yes. I am referring to that step! Why was it not intended to run on Windows? I thought it would. After all we have specified the workflow to use...

What is your vision here? I've been thinking about unifying on `.$inject = [token1, token2, token3]` (e.g. [this](https://github.com/karma-runner/karma/blob/master/lib/file-list.js#L240)) and exporting and documenting constants for all known DI tokens (e.g. [these](https://github.com/karma-runner/karma/blob/master/lib/server.js#L70)).

Something like karma-puppeteer-launcher should do (see [here](https://github.com/rsamec/karma-puppeteer-launcher/blob/master/index.js#L167)). Given that it is already doable and that this feature requires a very specific browser and a very specific browser launcher to work,...

Yes, we would be happy to accept a PR adding support for the ESM config file. https://github.com/tschaub/karma/commit/99f1a92ec85a1dd2efbcd0faf1ad653e4b29cf8e is a good start, but it will need some more work. In particular,...