Yaroslav Admin

Results 110 comments of Yaroslav Admin

The problem is in these lines: ``` plugins: [ 'karma-tsc-preprocessor' ], ``` By default Karma will load plugins from all installed NPM packages matching ‘karma-*’, but you have changed it...

Hmm, I was under impression that the out-of-order messages were fixed by https://github.com/karma-runner/karma/pull/3212 and https://github.com/karma-runner/karma/pull/3487. Are you able to reproduce it using the latest Karma? Having said that I agree...

While it was initially introduced for Safari, it is also used by other browsers which don't support WebSockets (e.g. IE9-IE10). Maybe unnecessarily, but IMO this change has a moderate risk...

@jginsburgn What exactly do you mean by "restart Karma"? Is it restart a test run? Restart a browser? Restart the whole server? What is the use case? A bit hard...

Not sure if we can implement a generic configuration reload with the current Karma architecture in a reasonable effort. If the idea is to simply restart Karma whenever a config...

There is a https://github.com/FortAwesome/angular-fontawesome/issues/85. But I will look if we can fix/improve this somehow.

I've looked at it and counter does behave as designed. The counter is supposed to be 1/4 of the icon's font size, that's why it is small, when icon size...

We can probably expose these 3 values as component inputs to make customisation more user friendly. Also looks like some fixes to icon positioning are required (`fa-layers` has fixed size...

I agree. We just need to come up with the good API to control it.

I would prefer to avoid making a breaking change right away. I'm leaning towards introducing a "per-component type" config as was suggested in https://github.com/FortAwesome/angular-fontawesome/issues/294#issuecomment-779667320 and allowing users to customize the...