Mark Nevill

Results 34 comments of Mark Nevill

I tried hacking together a solution that detects some cases that can be converted to discriminators, diff below. In the specific cases it can handle, it seemed to generate the...

In theory (based on the OpenAPI spec and its use of the JSON Reference spec and its use of the JSON pointer spec), to handle unions with inline object definitions,...

Looking at the OAS again, I notice the line regarding discriminators: > When using the discriminator, inline schemas will not be considered. However, the spec is also explicit that the...

Hi, stumbled across this, and had two questions about the units - ~Why milliseconds? Looks like its a float64 anyway, so the position of the decimal makes no technical difference,...

There's also two interceptor packages relating to selectively enabling other interceptors: `skip` and `selector`. So possible interface could something like one of the following: ``` auth.UnaryServerInterceptor(authFunc, auth.IgnoreMethods("grpc.health.v1.Health/Check")) auth.UnaryServerInterceptor(authFunc, auth.IgnoreServices(health_pb.Health_ServiceDesc) selector.UnaryServerInterceptor(auth.UnaryServerInterceptor(authFunc),...

Have checked ``` ./scripts/pack.sh && circleci orb validate packed-orb.yml Orb at `packed-orb.yml` is valid. ```

Indeed. Is there anything else worth updating as part of a breaking change? Could bump the default for `build_image_version`, `node_version`, `xcode_version`.

Also worth noting for this PR that `UseContainerSupport` is enabled by default

Do I need to do anything so that the semver bot understands the breaking change?

Hey, sorry for the long wait. Would you mind switching to more descriptive variable names? Names like `rs`, `tgs`, `nim`, and `ttgs` are hard to understand for anyone just skimming...