react-native-circleci-orb icon indicating copy to clipboard operation
react-native-circleci-orb copied to clipboard

Published 20 hours ago • verified publisher icon react-native-community

fix: remove _JAVA_OPTIONS parameter & environment

Open devnev opened this issue 2 years ago • 5 comments

Users should set org.gradle.jvmargs in their gradle.properties instead. This fixes #171 where build failures caused by the unexpected output from java commands.

BREAKING CHANGE: The java_options parameter has been removed. Specify your JVM options in the gradle.properties file or in the gradle_options with -Dorg.gradle.jvmargs= instead.

devnev avatar Jul 15 '23 09:07 devnev

Have checked

./scripts/pack.sh && circleci orb validate packed-orb.yml
Orb at `packed-orb.yml` is valid.

devnev avatar Jul 15 '23 09:07 devnev

Indeed. Is there anything else worth updating as part of a breaking change? Could bump the default for build_image_version, node_version, xcode_version.

devnev avatar Jul 15 '23 21:07 devnev

Also worth noting for this PR that UseContainerSupport is enabled by default

devnev avatar Jul 15 '23 21:07 devnev

Do I need to do anything so that the semver bot understands the breaking change?

devnev avatar Jul 15 '23 21:07 devnev

Do I need to do anything so that the semver bot understands the breaking change?

Yup we use semantic-release: https://semantic-release.gitbook.io/semantic-release/v/beta/

So your PR/Commit message should be updated

cortinico avatar Jul 15 '23 22:07 cortinico

Can this PR get merged?

bhandanyan-nomad avatar May 23 '24 01:05 bhandanyan-nomad

:tada: This PR is included in version 8.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

react-native-circleci-orb-bot avatar May 23 '24 10:05 react-native-circleci-orb-bot