David Widmann

Yep, it would be nice if we wouldn't make any assumptions about the support of the distributions we work with since we just need to be able to sample and...

This PR is included in https://github.com/TuringLang/DynamicPPL.jl/pull/406. That PR is not merged yet since some package was holding back Setfield.

It seems it was not tested and is not included in the documentation?

Yeah, that would be good. It's apparently also a jmd file but we don't support these here in DynamicPPL yet.

bors r-

The full stracktrace is ```julia julia> rand(toy()) # ERROR: type NamedTuple has no field x ERROR: type NamedTuple has no field x Stacktrace: [1] getproperty @ ./Base.jl:42 [inlined] [2] get(obj::NamedTuple{(),...

The problematic line is https://github.com/jw3126/Setfield.jl/blob/25f5f5a0e3f4cbc6f8c44955fb7fb0981b961e55/src/lens.jl#L187: We try to set the first entry of `x` via a `ComposedLens` (the outer lens accesses the field `:x`, and the inner one the first...

Good catch! Seems a bit difficult to provoke and test though since there are other definitions for `UnivariateDistribution`, `MultivariateDistribution`, and `MatrixDistribution`... Maybe it should just be removed, and if someone...

I'm slightly worried about the additional complexity introduced by the new abstract type and functions such as `wrapped_dist` and `wrapped_dist_type`. Can't we just add whatever definition was missing? In general,...

> It's just one abstract type and a very few standard boilerplate defs around it (`wrapped_distr()` etc). OTOH it allows to avoid the duplication of method definitions like `length()` etc....