Method calls itself - potential stack overflow

[mohdibntarek]

This function calls itself. There is another one with a !.

[devmotion]

Good catch! Seems a bit difficult to provoke and test though since there are other definitions for UnivariateDistribution, MultivariateDistribution, and MatrixDistribution... Maybe it should just be removed, and if someone uses a custom distribution that does not fit in these categories she has to implement DynamicPPL.reconstruct?

[mohdibntarek]

Sounds reasonable, or we can throw an error saying please implement this function.

[yebai]

This is likely fixed by the evaluate!! API.