Devin Smith

Results 190 comments of Devin Smith

It would be great to get something like this merged in. I've tested out shimming `docker-compose` to point to `docker compose` (v2), and the plugin is able to handle the...

In general, I think it would be nice if the innernet-server was able to implement the full interface of the admin client :)

> For mac M1 we do have precompiled wheel file support. You can just run `pip install connectorx` to install it. This works great for _local_ mac M1 development purposes,...

The test that passes in 3.2 and fails in 3.3 is essentially a (seeded) uniform random distribution of 10000 doubles in the range `[-10000.0, 10000.0]`. We check `abs((p_x-t_x)/p_x) < 0.005`...

Yeah. At least in the case of int/long, the JDK has `CharSequence` parsing support: ```java static int parseStringAsInt(JsonParser parser) throws IOException { if (parser.hasTextCharacters()) { final int len = parser.getTextLength();...

I understand there is nuance in assuming "public" means "public API". Looking through some related comments though, https://github.com/rallyhealth/weePickle/issues/117#issuecomment-1350169393 @pjfanning seems to suggest that `NumberInput` is part of the "public API"?...

Thanks for the additional context. Ultimately, I think I'll be making a case for additional methods on `JsonParser`, something like: ```java /** * Assumes {@link JsonToken#VALUE_STRING}, parses the string as...

I've got some of my own quantitative numbers motivating this. I'm essentially seeing an uplift from 14mm doubles / second -> 20mm doubles / second when using `ch.randelshofer.fastdoubleparser.JavaDoubleParser` from `getText`...

(Sorry if you saw my previous comment which I deleted, it was incorrect.) I think there's an opportunity to also improve the performance of `JsonParser#getDoubleValue`, which seems like it always...

@cowtowncoder Looks great, thanks! Quick test reading 100mm doubles out of an array, it looks like 2.18.0-SNAPSHOT parses doubles without extraneous allocation; went from ~6GiB to