Devin Smith

Results 190 comments of Devin Smith

Here's the conditions that cause the infinite loop: ![Screenshot from 2024-07-22 10-09-36](https://github.com/user-attachments/assets/d98e803c-3dd2-41a0-8e06-ccee04f1ac40) ``` lo = 4 hi = 5 searchValue = NaN valuesToSearch = [-Infinity, NULL_DOUBLE, -0.0, Infinity, NaN] ```...

```java /** * Insert new valuesToInsert into this SSMS. The valuesToInsert to insert must be sorted, without duplicates. * * The valuesToInsert and counts chunks will be modified during this...

The valuesToInsert are being sorted in `DoubleCompactKernel#compactAndCount` using `WritableDoubleChunk#sort(int, int)`, which is using `java.util.Arrays#sort(double[], int, int)` which does not sort according to DH sort order.

It appears even if `WritableDoubleChunk#sort(int, int)` is "fixed" (it may be breaking some other implicit assumption somewhere else, TBD), `DoubleSegmentedSortedMultiset#insertExistingIntoLeaf` can get into an infinite loop. Likely b/c `DoubleSegmentedSortedMultiset` is...

The sort order needs to be more clearly defined wrt `CompactKernel#compactAndCount` and `SegmentedSortedMultiSet#insert`; are one or both java array sorting order, DH sorting order, or a mix?

WritableChunk explicitly declares Java's "primitive" defined ordering ``` /** * Sort this chunk in-place using Java's primitive defined ordering. * * Of note is that nulls or NaNs are not...

There are a couple of GH tasks that call the `outputVersion` task and get the version: ```yaml - name: All Javadoc uses: burrunan/gradle-cache-action@v1 with: job-id: allJavadoc arguments: --scan outputVersion combined-javadoc:allJavadoc...

One thing that might help is to reduce the cycle time for what web-client-ui can declare compatibility with; for example, if we released jsapi-types nightly, that might give web-client-ui a...

A seeded PRNG is by its nature stateful; thus, there is no way to have a static function do what you want w/ a seeded PRNG (with the intention being...

Part of the issue might be the "unclear" semantics of the advanced filter "contains". It looks like the web UI is creating an 'InvokeCondition' w/ the "match" method and regex...