Devin Smith

Results 190 comments of Devin Smith

The code to create an empty catalog was based on the java iceberg quickstart, https://iceberg.apache.org/docs/1.6.0/java-api-quickstart/#using-a-hadoop-catalog. ```groovy import org.apache.hadoop.conf.Configuration import org.apache.iceberg.PartitionSpec import org.apache.iceberg.Schema import org.apache.iceberg.Table import org.apache.iceberg.catalog.TableIdentifier import org.apache.iceberg.hadoop.HadoopCatalog import org.apache.iceberg.types.Types...

This is missing documentation, as I want to make sure there's some agreement on the interfaces before proceeding.

This is partially related to #5868, at least for providing a refactoring of the TableDefinition logic and exposing it to end users for the static entrypoints.

We might consider that the catalog type (as written by pyiceberg) for a `byte[]` type would be better represented as a BinaryType (as opposed to List) in catalog. That said,...

Related https://github.com/dependabot/dependabot-core/issues/1986

It also appears that `WritableCharChunk#sort` is incorrect when `offset != 0`

This may not be a bug, as it is "consistent" with the javadocs: ``` /** * Sort this chunk in-place using Java's primitive defined ordering. * * Of note is...

> Of note is that nulls or NaNs are not sorted according to Deephaven ordering rules. Afaict, `Arrays.sort` *does* sort NaNs in the same way DH does - NaNs come...

Removing the SortFixup region from WritableCharChunk does not cause _any_ tests to fail (normal, nor nightly). This surprises me very much; either, code downstream of WritableCharChunk.sort() 1) does their own...

https://iceberg.apache.org/spec/#sorting is relevant info on how iceberg handles double. We may want to create an issue more generally about floating point (in)consistencies in DH.