Andrew Berry
Andrew Berry
The GitHub actions are assuming that global binaries are turned on. We need to make it so they check if task lives in the global path or vendor/bin.
@justafish I made the improvement in https://github.com/Lullabot/drainpipe/pull/207/commits/ca13661b86730a680608ed9e3a012bb66ef6283f and builds pass now. Back to you!
Based on https://github.com/Lullabot/drainpipe/pull/355 I believe our tests on main are broken.
I've marked this as high because I know of at least 3 client projects the bugs this solves has affected.
I believe we've hit our multidev limit or similar as we're getting errors running wipe that are unrelated to this PR: https://github.com/Lullabot/drainpipe/actions/runs/8297688089/job/22709329644?pr=207
Following up from https://github.com/Lullabot/drainpipe/pull/207#issuecomment-2056790567, we think this is solved by adding `composer install` as a ddev post-start hook. I don't know if that makes sense for us to ship automatically,...
I've pushed up various fixes from IDE checks and phpstan. I still think this is worth merging, but I wonder if we considered using https://github.com/bamarni/composer-bin-plugin instead? In particular, I was...
I'm happy to resolve conflicts, but I'd appreciate an initial 👍 on the approach before doing so.
I've pulled out a few PRs. Once those are in, I'll do a last one for setting strict types.
The remainder of this is at https://github.com/Lullabot/drainpipe/pull/617.