Andrew Berry

Results 149 comments of Andrew Berry

Adding the type makes sense. I'm not 100% sure about the dependency thing. I've been only doing Drupal 8 work for the past two years or so, but packages.drupal.org reads...

(from a prior chat we had) a few thoughts. - there's no static caching the way you have it now, so multiple calls in the same request will still hit...

The actual cache code looks fine, though I've only done a static review. It will eventually need unit tests on the new code before we merge it in.

I wonder if PHP 5.4 isn't calling the __construct() method on the stream wrapper. I'd be surprised if this was an apache issue. Can you drop a watchdog() or error_log()...

If your host allows it, you can override memory settings in your settings.php by calling ini_set(). However, I don't think this is a memory_limit setting, but the upload size. See...

@charleslouis your hack would mostly work, except the filesize column in {files_managed} would be wrong. I have seen the CORS and FileField Sources modules, but both of those need to...

This fails if you run tests on servers that aren't EC2 (like local environments). ``` PHPUnit 4.6.6 by Sebastian Bergmann and contributors. Configuration read from /Users/andrew/vagrant/d7/www/docroot/sites/all/modules/amazons3/phpunit.xml ...............F................................................. 65 / 69...

Can you check to see if feeds is calling `file_stream_wrapper_uri_normalize()`? If not, and it's creating a URL without a bucket, we never get a chance to set the default bucket...

Oh right... so I've documented that patch as being required for Media module. But, it's entirely possible it's needed for other modules. Perhaps I should make that patch required, even...

I'm having a similar issue, but it's not just Ice. Other sensors will show no value (like temperature) or not update properly (like opening a door). ``` This error originated...