Andrew Berry

Results 378 comments of Andrew Berry

I think I've forgotten some of this over the past year. Looking again, I see a POST to a URL-encoded form to create a statistic file like this: ``` {"request":{"id":68,"session-id":1301001031,"priority":false,"actions":[{"id":0,"method":"uploadBMStatisticsFile","xpath":"Device","parameters":{"startDate":"20240211","endDate":"20240217"},"event-id":"36"}],"cnonce":REDACTED,"auth-key":"REDACTED"}}...

I think a file of known issues to skip is good. It would be a small bump in development on open PRs ("why did my PR all of a sudden...

Things I like: 1. Simple - in practice, just URLs and comments. 2. Flexible - would presumably support any URL. I wonder: 1. _does_ every vulnerability shown have a URL...

Dave and I had a chance to discuss this today. We would like to separate out the security jobs and recommend they run on a daily schedule. In the future,...

Talked about this today: - "We agreed this is a great idea" - "Andrew is going to fix some little bits" - "lets ship it"

@justafish my guess is this is erroring because settings.php isn't including settings.ddev.php, because we run composer install after ddev is configured. Can you pick it up from here?

@elvism-lullabot I added you as a collaborator to this project. Feel free to push to this branch.

Yeah, I would get things working here first, especially the test production build one.

@justafish this is ready for a review again. The one failing test appears to be unrelated, as its failing on main and has to do with yarn and nightwatch which...

I ran the failed test jobs locally until the point where the environment was being pushed to pantheon. The job failed with: ``` 547 > In SiteInstallCommands.php line 181: 548...