Nitin Madnani

Results 127 comments of Nitin Madnani

I tried modifying the code to move the `hue` variable from the `FacetGrid()` instantiation call to the `map_dataframe()` call instead: ```python ... g = sns.FacetGrid(df_fs, row="metric", col="learner_name", height=2.5, aspect=1, margin_titles=True,...

I figured out how to make this work by following the recommendations that: - hue levels and keywords should be handled by the plotting function and not `FacetGrid` - we...

Indeed, `catplot` would have been simpler and I did try it but the marker size seemed to be much larger and less to my liking than if I used `FacetGrid`.

Sure! Attached are two plots that are saved in 300 DPI using `plt.savefig()`. The first was generated using FacetGrid + pointplot and the second was generated using catplot. I am...

Ah, sorry. Please take a look at the `generate_learning_curve_plots()` function [here](https://github.com/EducationalTestingService/skll/blob/713-upgrade-scikit-learn/skll/experiments/output.py#L83).

Apologies, that branch was probably merged by the time you got to it. It's now in the [main branch](https://github.com/EducationalTestingService/skll/blob/main/skll/experiments/output.py#L83).  

Yeah, as I mentioned, I didn't use `catplot` in production because of the marker size. Here's a [gist](https://gist.github.com/desilinguist/f2998789053286a83ab4585706efe1ed) that shows how I combined the `FacetGrid` and `pointplot` calls together. However,...

Hi @szorowi1. Thanks for opening this PR! FYI, we'll also need tests to cover the newly added code before we can review. If you don't have time to add those,...

Thanks 🙏! Take a look at `tests/test_expected_rotator.py` to see examples of tests.

Hi @szorowi1, this is a great idea! We will try to include this in the next release.