random initial values for rotation matrix in GPA rotations

Open szorowi1 opened this issue 3 years ago • 3 comments

A first pass attempt to address #116. Code has been modified as suggested in that issue.

Sep 20 '22 20:09 szorowi1

Hi @szorowi1. Thanks for opening this PR! FYI, we'll also need tests to cover the newly added code before we can review. If you don't have time to add those, one of us can add them when we have time.

Sep 22 '22 11:09 desilinguist

Absolutely, I can do that! If you have any thoughts about specific tests to implement, let me know. Otherwise I'll give it a shot!

Sep 22 '22 12:09 szorowi1

Thanks 🙏! Take a look at tests/test_expected_rotator.py to see examples of tests.

Sep 22 '22 12:09 desilinguist