Nitin Madnani comments

Results 127 comments of


                                            Nitin Madnani

Try solution for kernel RuntimeErrors

We haven’t really tried it yet :)

The `preprocessed_features` notebook hangs when using a large number of features

Is this still an issue @jbiggsets ?

Run flynt on all code and add it as a pre-commit hook

Thank you so much for taking this on @srhrshr! I'll take a look next week!

Consistent approach to warnings

This is actually addressed in the Python [logging HOWTO](https://docs.python.org/3/howto/logging.html): > warnings.warn() in library code if the issue is avoidable and the client application should be modified to eliminate the warning....

Consistent approach to warnings

On a related note, we should be using `FutureWarning` for deprecation warnings and not `DeprecationWarning` since that's what the Python documentation [recommends](https://docs.python.org/3/library/exceptions.html#FutureWarning) and this is what scikit-learn has recently done.

Consistent approach to warnings

@aloukina this is done right?

Add suppress_warnings argument to various metrics

Great idea! May be we should also have an overall verbose/quiet option on the command line for the `run` command that propagates all the way down into the code and...

Add best practices for sharing reports to documentation.

Do we still need to address this?

Resource warning when running tests

Sounds like a temporary file isn't being closed properly in a test.

Resource warning when running tests

@aloukina do you see this warning on your Mac or in the TravisCI build?