Alexander M. Turek

1. Why does your class access the clock in its constructor? 2. You access the clock already before any calling code has the chance to call `setClock()`. Why do you...

I don't feel comfortable with adding a very specific flag about `DateTime` objects to very generic class such as `Criteria` which otherwise wouldn't know anything about DateTime. Once we merge...

> Definetly good point! I was wondering about that as well, but ultimately the `DateTime`s were the only value objects built into PHP that I was aware of. `Number` is...

> Maybe adding this feature on `Criteria` in doctrine/collections is not too difficult. On the other hand, how would you envision it to work at the ORM level in doctrine/orm,...

> However, all of our constant declarations are only dependent on libcurl and PHP version numbers; They do not check the availability of those features. Understood. But this PR ignores...

> I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support. No, the tests are failing on DBAL versions...

That makes perfect sense. Thank you for the explanation.

Please explain what problem exactly you're attempting to solve with your change. And please have a look at the failing tests.

@SerheyDolgushev Looks like this PR did not get much traction, which is probably due to its complexity and the nieche problem that it solves. We don't introduce this kind of...

> @derrabus This command was not initially considered in the tests. Really? https://github.com/symfony/symfony/blob/da3a2805abbfd7180d52136febd08c21b97c7055/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/RouterDebugCommandTest.php