orm icon indicating copy to clipboard operation
orm copied to clipboard

Use enum values from enumType in DiscriminatorColumn and check DiscriminatorMap values against it

Open whataboutpereira opened this issue 11 months ago • 3 comments

Fix for issue #11794.

Currently the values of enumType in DiscriminatorColumn are ignored which results in an error when generating a migration:

Doctrine\DBAL\Platforms\MySQL80Platform requires the values of a ENUM column to be specified.

Fixed by populating values from the enum and also prevent invalid entries in DiscriminatorMap.

whataboutpereira avatar Jan 23 '25 09:01 whataboutpereira

I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support.

whataboutpereira avatar Jan 25 '25 12:01 whataboutpereira

I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support.

No, the tests are failing on DBAL versions without EnumType.

derrabus avatar Jan 25 '25 12:01 derrabus

I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support.

No, the tests are failing on DBAL versions without EnumType.

Unfortunately I'm out of ideas how to proceed from here. :)

whataboutpereira avatar Mar 04 '25 13:03 whataboutpereira

Okay, got the history cleaned up now.

whataboutpereira avatar Jun 10 '25 09:06 whataboutpereira

Auto closed due deleting the base branch or is there still hope to get something like this in?

whataboutpereira avatar Jul 04 '25 07:07 whataboutpereira

Sorry, it was closed because I deleted the branch. Feel free to reopen against another branch.

greg0ire avatar Jul 04 '25 14:07 greg0ire