Mark Scherer

Results 880 comments of Mark Scherer

We should probably add some examples here in the docs.

Could this maybe be its own filter? And we try to support this besides the other cases?

You mean $templatePath = __DIR__ . DS . 'Template' . DS; ? I agree that having a `templatePath()` wrapper that also allows a configured alternative would make sense. Do you...

I might need a bit help for the remaining errors. ``` 1) Migrations\Test\TestCase\Command\BakeMigrationDiffCommandTest::testEmptyHistoryNoMigrations Symfony\Component\Console\Exception\InvalidArgumentException: The "configuration" option does not exist. /home/runner/work/migrations/migrations/vendor/symfony/console/Input/Input.php:158 /home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:239 /home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:281 /home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:117 /home/runner/work/migrations/migrations/src/Command/Phinx/CommandTrait.php:66 /home/runner/work/migrations/migrations/src/Command/Phinx/MarkMigrated.php:112 ``` Any idea why...

No, I updated those references, tests should now run.

Yeah, wrong branch as well, I guess It should probably to towards 3.x now. The 3.x release was bad, without those changes :/

Do we have any blockers from Migrations side? I remember there were some tests failing that we didnt know how to handle.

@markstory You could add if (Configure::read(debug)) into it?

The CS issue is "hacked" for now with https://github.com/cakephp/cakephp-codesniffer/pull/320 We should still looking into a phinx solution that allows namespace migration class names, though. According to https://github.com/cakephp/phinx/blob/master/docs/en/namespaces.rst#psr-4-compliance this should already...