Mark Scherer

Results 880 comments of Mark Scherer

We lose the "semantic type", so bool/enum is not possible anymore, as shown above, also some other type specific meanings are lost.

So both bake and migrations (fixtures) need it to make proper generated files from DB. What do you think? Can we try to go into that formalized comment field here...

Ignore anything that doesnt fit the very narrow regex IMO. #\b(length|...):\d+;# So no BC issue for anyone who is using them differently.

This might need a bit more data on how to reproduce this. Like the migration file content etc. Maybe you want to also make a PR to fix the type...

Can you Show the details? Like URLs and Controller code?

Are you able to reproduce sth similar with demo actions on the sandbox? https://github.com/dereuromark/cakephp-sandbox That would help, as once reproduced it is easy to track down and find the issue...

Do u have a fix as well? That would solve the issue?

Are u able to make a PR with suggested change?

Yeah https://github.com/alt3/cakebox-console/blob/dev/src/Template/Bake/vhost_nginx.ctp#L29 needs to be switched over to 7.2 once the upgrade is complete for example.

Gotcha PS: Interesting, why it didnt fix it for me. But all right, I will retry.