Derek O'Callaghan

Results 26 comments of Derek O'Callaghan

Thanks Ryan, I'll do that and also watch out for any updates to https://github.com/pangeo-forge/pangeo-forge-recipes/issues/376

Here's the current draft of the recipe port, containing a new `IcsWindSpeedDirection` transform, that appears to run successfully: ```python import apache_beam as beam import dask import dask.array as da from...

It looks like the `time` values aren't being stored correctly in the output Zarr, i.e. in the output above: ```python In [88]: ds.time.values Out[88]: array(['2015-01-16T00:00:00.000000000', '2015-01-16T00:00:00.000000000', '2015-01-16T00:00:00.000000000', '2015-01-16T00:00:00.000000000', '2015-01-17T00:00:00.000000000', '2015-01-17T00:00:00.000000000',...

This might be a candidate for the proposed [separate issue for migrating tutorials from notebooks -> scripts (with CI testing)](https://github.com/pangeo-forge/pangeo-forge-recipes/issues/483#issuecomment-1577266822)

I'm not sure yet what's causing the test failures. I added a test function to `tests/test_serialization.py`, but it wasn't run according to the logs. I wouldn't have thought the code...

As mentioned by @cisaacstern, the failing tests appear to be unrelated to these PR changes. More details in https://github.com/pangeo-forge/pangeo-forge-recipes/issues/451#issuecomment-1350219102

> If, once hashes are used in Pangeo Forge Cloud, we then realize that `client_kwargs` contains something we want included in the hash, we can circle back and work on...

I'm currently working on the PR for this including corresponding test cases, and it seems that `aiohttp.BasicAuth` isn't an issue as it can be serialized to json without calling `either_encode_or_hash()`,...

I'll take a look to see whether this is still an issue following the `beam-refactor` release

> > What do you think about dropping this design requirement > > > Which one? Supporting older versions of pangeo_forge_recipes with newer versions of runner? > > Yes, this...