pangeo-forge-recipes icon indicating copy to clipboard operation
pangeo-forge-recipes copied to clipboard

Published 20 hours ago • verified publisher icon pangeo-forge

Exclude `fsspec.open_kwargs["client_kwargs"]` from pattern hash computation

Open derekocallaghan opened this issue 2 years ago • 3 comments

Fixes #443 using the proposed solution. Corresponding test cases added.

derekocallaghan avatar Nov 30 '22 12:11 derekocallaghan

I'm not sure yet what's causing the test failures. I added a test function to tests/test_serialization.py, but it wasn't run according to the logs. I wouldn't have thought the code changes would cause the current test failures, I'll look into it.

derekocallaghan avatar Nov 30 '22 12:11 derekocallaghan

Thanks @derekocallaghan. On first read, both the fix and the test look quite thorough and appropriate to me. I'm also unclear on what's causing the test failure. It seems possibly unrelated to this PR.

cisaacstern avatar Nov 30 '22 18:11 cisaacstern

As mentioned by @cisaacstern, the failing tests appear to be unrelated to these PR changes. More details in https://github.com/pangeo-forge/pangeo-forge-recipes/issues/451#issuecomment-1350219102

derekocallaghan avatar Dec 21 '22 16:12 derekocallaghan