Derek Su
Derek Su
> Everything looks good! @derekbit Could you squash the commits into meaningful ones? @bachmanity1 Thanks @derekbit @ahnuyh for your reviews. I'm reviewing the PR as well.
cc @shuo-wu @PhanLe1010 @c3y1huang for review
@c3y1huang Could you do a final review? Thank you.
Creation timestamp is created when taking a snapshot. Unlike v1 volume, the creation timestamp is stored in meta file, so it won't be changed after rebuilding. After discussing with @shuo-wu,...
> Creation timestamp is created when taking a snapshot. Unlike v1 volume, the creation timestamp is stored in meta file, so it won't be changed after rebuilding. > > After...
@DamiaSan Please ignore the previous comment (already deleted right after posting it🥲) Sorry for misunderstanding your idea before. > For the snapshots, what we can do is to pass a...
Hello @DamiaSan, Before moving it to review, need to integrate to go-spdk-helper, longhorn-spdk-engine and longhorn-instance-manager as well.
@DamiaSan Is it resolved? cc @shuo-wu
> I was thinking that, if we let a snapshot to store new xattr after its creation (like for example the checksum), this functionality to pass xattr at snapshot creation...
> We have decided to calculate the snapshot checksum inside SPDK, so there is no need to implement the functionality to add an xattr after the snapshot creation. So the...