Derek Su
Derek Su
@m-ildefons Just reviewed the changes. The commits remove the dead codes, check the unhandled variables, and fix incorrect formatting errors. Good job! Can you help resolve the conflicts and address...
@FrankYang0529 Can you help review this PR and see if we can close the PR? I think most of the fixes have been included in your golint fix PR. cc...
The PR has been pending for a long time and without update. Most of the warnings and errors are fixed by @FrankYang0529. Let's close it. cc @innobead
> For v2 volumes, it seems that we cannot do snapshot auto deletion together with unmap without modifying spdk_tgt. Is asking users to set up a snapshot deletion recurring job...
> > I think we can improve it in the future if users request the feature. WDYT? > > This feature is for Longhorn only. Should we modify spdk code...
Reviewd in https://github.com/longhorn/longhorn-manager/pull/2642/commits
``` go: downloading go1.22.2 (linux/amd64) # k8s.io/component-base/metrics/testutil vendor/k8s.io/component-base/metrics/testutil/metrics.go:73:59: undefined: expfmt.FmtText time="2024-05-13T09:00:29Z" level=fatal msg="exit status 1" make: *** [Makefile:11: ci] Error 1 ```
@james-munson Could you update the status? Thanks.
Hello @@jangseon-ryu @hookak Could you help review the PR? Thanks.
Hello @hookak Could you help review the PR when you are available? Thanks.