Derek Su
Derek Su
> > @shuo-wu did you mean to keep this part "and it will skip the auto-deletion for the failed backups?" > > Right. This part is what I suggest in...
> Putting this state check in the revision counter check function looks a little bit weird... Will the replica process check the state during the starting stage? Agreed. Actually, the...
> Yes, I prefer a new function `checkReplicasState` for checking the state before the `checkReplicasRevisionCounter`. > due to the complexity of the replica state, more investigation is needed. Sure.
In current design, the latest busybox image is pulled. For security, I think it's fair. User can use a specific version and imagePullPolicy for their use cases.
@ClenchPaign The error in the stackoverflow ticket is fixed. You can try the master branch as well, but 0.0.21 is the latest stable version.
@dchirikov Could you please resolve the conflict first? I will review it after resolving the conflict. Thanks.
@dchirikov Sure thing. Take your time.
> Hey guys. Any chance this PR will be merged? It being open for more than a year already. Yeah, I will review again and merge it after rebase. Thank...
@dfoxg Sorry for the late review. I will finish the review by next Friday.
@dchirikov In general, LGTM. Could you please add an example ([examples](https://github.com/rancher/local-path-provisioner/tree/master/examples)). A test ([examples](https://github.com/rancher/local-path-provisioner/tree/master/test)) is also appreciated.