Christopher Howard

Results 15 comments of Christopher Howard

Going to close this until I can hop off of swaps to address e2e issues.

Okay, I ran through the following: mainnet eth -> mainnet usdc: This looked normal to me. https://recordit.co/NFfilCQWz0 mainnet eth -> arbitrum dai: Swap went through, didn't see a balance update....

@estebanmino commit: 9baa266d1c76cc5a5e36ab093af66cc066e5c8c8 case you caught when app is unaware of any L2 output token related data: https://recordit.co/tKiAdNDV57 original case of disappearing l2 tokens w/o mainnet addresses: https://recordit.co/P7zlNJ7Vnh

> Looks like this is associated with [RNBW-2584](https://linear.app/rainbow/issue/RNBW-2584/separate-out-asset-price-data-asset-balance-data-asset-metadata). I've moved this ticket to the Code Foundations project and we'll address it as part of state management. > > @derHowie do...

Hide/unhide functionality works, but if you pull up the cmd-k menu while you're on the assets list then return after hiding a token, the list's rendering seems to be messed...

> @derHowie is this ready for review? yes

@DanielSinclair your crash is not occurring in the branch, however I saw a different issue while attempting to repro: https://www.loom.com/share/4d0c018d80384a07b9347021e2549c13 I'm guessing from the description that these changes were meant...

@DanielSinclair Alright. Do you mind if I close this one? I can raise another PR if I get a grasp on what we want moved over from the app.

@DanielSinclair moving this to draft, because we've since added a couple tickets to my queue that are related to these changes. I'll include those additional changes and reopen.

hey @greg-schrammel, did we end up getting blocked / deprioritizing this?